Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: expose inc prop on OverlayTriggerProps #1086

Merged
merged 1 commit into from
Nov 11, 2024
Merged

fix: expose inc prop on OverlayTriggerProps #1086

merged 1 commit into from
Nov 11, 2024

Conversation

apattersonATX-HB
Copy link
Contributor

I've had to write this

      <ButtonMenu
        // @ts-ignore: it works but prop isn't exposed
        trigger={{ icon: "verticalDots", inc: 2.3 }}

more than a few times lately 😄

stephenh
stephenh approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@stephenh stephenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! The inc: 2.3...makes me think it'd be great to have more logical/aliases sizes like small/big/but shrug.

@apattersonATX-HB apattersonATX-HB merged commit 2cd23c4 into main Nov 11, 2024
6 checks passed
@apattersonATX-HB apattersonATX-HB deleted the fix/add-icon-inc-to-overlay-trigger branch November 11, 2024 16:13
homebound-team-bot pushed a commit that referenced this pull request Nov 11, 2024
chore(release): 2.370.1 [skip ci]
9815324 
## [2.370.1](v2.370.0...v2.370.1) (2024-11-11)

### Bug Fixes

* expose `inc` prop on OverlayTriggerProps ([#1086](#1086)) ([2cd23c4](2cd23c4))
@homebound-team-bot
Copy link

🎉 This PR is included in version 2.370.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenh stephenh stephenh approved these changes

@ksk5280 ksk5280 Awaiting requested review from ksk5280 ksk5280 is a code owner

@chr1sjf0x chr1sjf0x Awaiting requested review from chr1sjf0x chr1sjf0x is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apattersonATX-HB @homebound-team-bot @stephenh